Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid removing shadowed imports that point to different symbols #10387

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

charliermarsh
Copy link
Member

This ensures that we don't have incorrect, automated fixes for shadowed names that actually point to different imports.

See: #10384.

@charliermarsh charliermarsh added the bug Something isn't working label Mar 13, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) March 13, 2024 15:43
@charliermarsh charliermarsh merged commit d59433b into main Mar 13, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/f branch March 13, 2024 15:44
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@zanieb
Copy link
Member

zanieb commented Mar 13, 2024

@charliermarsh you merge machine — why not #10388? doesn't it make more sense to remove the first import?

@charliermarsh
Copy link
Member Author

I explained a bit in the PR summary why that isn't really ideal. These are typically going to be "the same" import anyway so this felt ok to me.

@zanieb
Copy link
Member

zanieb commented Mar 13, 2024

Hm okay, can revisit later if we need to. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants